Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4200 closed enhancement (fixed)

Write a patch that tracks (bridge) server descriptor downloads (total requests per day, unique requests)

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Deliverable-Nov2011
Component: Core Tor/Tor Version:
Severity: Keywords: tor-auth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

Implemented in branch ticket4200 in my repository. Some review would be lovely, but this doesn't have to go into mainline tor currently. We have to deploy it on Tonga.

Tested in a private network with a few bridges and a bridge authority

comment:2 Changed 8 years ago by karsten

Patch looks good. Sebastian made a few tweaks based on my comments on IRC (single stats output line, appending to stats/served-desc-stats instead of overwriting). I think it's safe to run this patch on Tonga and/or merging it into master (where it will only be used by Tonga anyway).

comment:3 Changed 8 years ago by nickm

The "rep_hist_add_desc_stats" identifier seems vague. How about rep_hist_note_desc_served() or something?

The documentation for "served_descs" should say what the keys and values of the map are.

I'd be more comfortable if rep_hist_desc_stats_init() were idempotent -- that is, if it did "if (served_descs) return;" rather than "tor_assert(!served_descs)".

In rep_hist_format_desc_stats, if time moves backwards we'll be sad.

As a separate patch, we should raise the "write a stats file code" into a function of its own. I added ticket #4282 for that.

Otherwise looks fine.

comment:4 Changed 8 years ago by Sebastian

I think I addressed your concerns (except #4282, which is separate) in branch ticket4200. Please check it out?

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Squashed and merged.

comment:6 Changed 7 years ago by nickm

Keywords: tor-auth added

comment:7 Changed 7 years ago by nickm

Component: Tor Directory AuthorityTor
Note: See TracTickets for help on using tickets.