Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4201 closed defect (fixed)

Bridges should not perform DNS self-tests

Reported by: rransom Owned by: warms0x
Priority: Low Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy bridge-concealment tor-bridge
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From run_scheduled_events in src/or/main.c:

  /** 9. and if we're a server, check whether our DNS is telling stories to
   * us. */
  if (is_server && time_to_check_for_correct_dns < now) {
    if (!time_to_check_for_correct_dns) {
      time_to_check_for_correct_dns = now + 60 + crypto_rand_int(120);
    } else {
      dns_launch_correctness_checks();
      time_to_check_for_correct_dns = now + 12*3600 +
        crypto_rand_int(12*3600);
    }
  }

is_server in the outermost if statement's condition should be public_server_mode(options).

Child Tickets

Attachments (1)

0001-Avoid-running-DNS-self-tests-if-we-re-operating-as-a.patch (1.1 KB) - added by warms0x 8 years ago.
Round two of the change, proper changes/ addition and tested on maint-0.2.2

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by Sebastian

See also #965

comment:2 Changed 8 years ago by nickm

Agreed; wants a patch.

comment:3 Changed 8 years ago by warms0x

Status: newneeds_review

I suppose it's not too big of a challenge if you say exactly what needs to be done :)

I'll try a harder one next

Changed 8 years ago by warms0x

Round two of the change, proper changes/ addition and tested on maint-0.2.2

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Tweaked the changes file a little, merged it to 0.2.2 and master. Thanks!

comment:5 Changed 7 years ago by nickm

Keywords: tor-bridge added

comment:6 Changed 7 years ago by nickm

Component: Tor BridgeTor
Note: See TracTickets for help on using tickets.