Stem / TorCtl Integration
As the saying goes: commit early, commit often. Rather than completing stem then tossing it over the wall, the stem-integration branch of my TorCtl repo [1] has a bite sized commit to start making use of it: https://gitweb.torproject.org/atagar/pytorctl.git/commitdiff/d3a12d5724e44dac9096a56d0706bbc342efa304
This replaces TorCtl's _read_reply and related util functionality with stem's ControlMessage class and parsing [2], which has unit [3] and integration [4] tests. Doing a series of small commits like this will let TorCtl users take advantage of the tests I'm writing for stem without a need for changes on their part.
Cheers! -Damian
PS. Historically my TorCtl patches collect a lot of dust, so I'm testing the waters a bit with this ticket. If there isn't time or interest on your part to make this happen then it ain't gonna happen and I'll focus on stem solely rather than using it as a means to improve TorCtl.
[1] https://gitweb.torproject.org/atagar/pytorctl.git/shortlog/refs/heads/stem-integration [2] https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/types.py [3] https://gitweb.torproject.org/stem.git/blob/HEAD:/test/unit/message.py [4] https://gitweb.torproject.org/stem.git/blob/HEAD:/test/integ/message.py