Opened 8 years ago

Closed 8 years ago

#4264 closed defect (fixed)

ExitAuthority crash due to improper use of class SSLTestResult

Reported by: aagbsn Owned by: mikeperry
Priority: Medium Milestone:
Component: Core Tor/Torflow Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

strings "NoExit" and "NotStored" are passed for to the SSLTestResult constructor in a few cases, but the parent constructor doesn't expect a string:

if exit_obj:
 self.exit_node = exit_obj.idhex
 self.exit_name = exit_obj.nickname
 self.exit_ip = exit_obj.ip
 self.contact = exit_obj.contact  

Child Tickets

Change History (2)

comment:1 Changed 8 years ago by aagbsn

I think we can just replace "NoExit" with None. I'm not sure that "NotStored" for the parameter ssl_site is right though. We should do away with all these positional arguments.

https://github.com/aagbsn/torflow/tree/4264-bad-argument-to-ssltestresult

note: untested

comment:2 Changed 8 years ago by mikeperry

Resolution: fixed
Status: newclosed

Looks mostly harmless. Merged. We'll see how often we get mails with an exit of None.

Note: See TracTickets for help on using tickets.