Opened 8 years ago

Closed 5 years ago

#4279 closed enhancement (fixed)

Update INSTALL for Windows TBB build

Reported by: Shondoit Owned by: erinn
Priority: Medium Milestone: TorBrowserBundle 2.2.x-stable
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: INSTALL, build, tbb, needs-triage
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

INSTALL for Windows is outdated and needs to be reviewed. ot updating might hinder user contributions because they're not able to get a working build to hack on.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by Shondoit

I would also recommend using a dedicated folder for all requirements to lose dependencies on version numbers and os architecture.

For example, right now these are used in windows.mk
MING=/c/MinGW/bin
QT_LIB=/c/Qt/$(QT_VER)/bin
WIX_LIB="/c/Program Files (x86)/Windows Installer XML v3.5/bin"
PYTHON=/c/Python26/python.exe
SEVENZIP="/c/Program Files/7-Zip/7z.exe"

If all these were, for example, in C:\BuildTools\ then WIX_LIB would not be dependent on a 64-bit specific folder and Python would not be dependent on it's version number and be simpler to change in the future.
I suggest, for the examples above, but not limited to:
MING=/c/BuildTools/MinGW/bin
QT_LIB=/c/BuildTools/Qt/bin
WIX_LIB="/c/BuildTools/WIX/bin"
PYTHON=/c/BuildTools/Python/python.exe
SEVENZIP="/c/BuildTools/7-Zip/7z.exe"

This is merely a suggestion.

comment:2 Changed 8 years ago by Sebastian

Owner: changed from helix to erinn
Status: newassigned

reassigning to erinn, there's no helix on trac

comment:3 Changed 8 years ago by mikeperry

Component: Tor BrowserTor bundles/installation

comment:4 Changed 5 years ago by erinn

Keywords: needs-triage added

comment:5 Changed 5 years ago by erinn

Resolution: fixed
Status: assignedclosed

Closing.

Note: See TracTickets for help on using tickets.