Opened 6 years ago

Last modified 21 months ago

#4281 new defect

Usage popup not unique clients

Reported by: atagar Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Nyx Version:
Severity: Normal Keywords: connections
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The usage popup either shows the number of client connections we've had per a locale or exit connections per port. For the client counts this isn't very useful since it counts *each* connection that a person makes so it's more of an activity metric rather than showing how many people are using you.

I should only count each source ip once.

Child Tickets

Change History (5)

comment:1 Changed 6 years ago by arma

Tor as a relay also counts client usage, and it does it I think in the way you have in mind. It even fuzzes the numbers slightly, which might be considered a feature if people accidentally log the output plus timestamps.

See 'getinfo status/client-seen' for details. As of a recent 0.2.2.x, it gives you an answer before the 24 hour uptime mark too.

comment:2 Changed 6 years ago by atagar

I opted to avoid clinet-seeen because arm had the data and "This GETINFO option is currently available only for bridge relays."

comment:3 in reply to:  2 Changed 6 years ago by arma

Replying to atagar:

I opted to avoid clinet-seeen because [...] "This GETINFO option is currently available only for bridge relays."

Good point. I wonder if Tor should start offering it for normal relays too.

It seems silly to duplicate the logic in both places. For example, does arm know to check if it's a known relay IP address and not include it in the client stats then? Seems like it's easy for the logic in each place to diverge.

comment:4 Changed 6 years ago by atagar

For example, does arm know to check if it's a known relay IP address and not include it in the client stats then?

Yup. Arm needs to determine if IPs belong to a known relay or not so it can scrub client/exit connection details. Though I also needed a function for converting ip/port combinations into relay fingerprints so this is just an existence check on that.
https://gitweb.torproject.org/arm.git/blob/HEAD:/src/util/torTools.py#l2100

comment:5 Changed 21 months ago by atagar

Keywords: connections added
Priority: MediumLow
Severity: Normal
Note: See TracTickets for help on using tickets.