Opened 8 years ago

Closed 8 years ago

#4290 closed defect (fixed)

Vidalia should not let users check "Use Bridges" without entering any

Reported by: mikeperry Owned by: chiiph
Priority: High Milestone:
Component: Archived/Vidalia Version:
Severity: Keywords:
Cc: arma, anonym@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The "My ISP blocks connections to the Tor network" checkbox has some funky behavior to it. The first time I tried to use it, I clicked the checkbox, pasted my bridge in the text entry line, and clicked OK. I did not know I had to click the + sign next to the text entry box.

Vidalia happily let me do this, and I thought I was using bridges. Until Tor didn't work.

Something is wrong with this picture. Either Vidialia should not have let me clicked OK until I actually properly added a bridge after checking the checkbox, or it should have popped up a message, or we should redo the bridge entry entirely so it is not so subtle about what has been entered and what is just a textfield.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by arma

Priority: normalmajor

Yeah. This is entirely a Vidalia bug I believe: if it tries to setconf anything on the Tor side, Tor would have failed and Vidalia would have noticed. I guess Vidalia just silently doesn't even try to setconf.

Sounds like a bugfix that we should aim to get into the 0.2.x series.

comment:2 Changed 8 years ago by anonym

Cc: anonym@… added

For historical reasons it's perfectly reasonable to check the "My ISP blocks..." option without entering any bridges. From the Vidalia Help -> Configuring Tor -> Network Settings:

Even if you do not know any bridge relay addresses, checking this checkbox may still be helpful. Tor will encrypt its directory requests, which can defeat blocking mechanisms that try to filter Tor's requests for information about other relays. If connections to normal Tor relays are also blocked, then you will need to learn a bridge relay address somehow and add it here.

E.g. it is overloaded as an option for setconf TunnelDirConns to 1 in older Tors that had it disabled by default; Vidalia will only setconf UseBridges to 1 if there was at least one bridge added as well. Imho the lack of one-to-one correspondence between Tor's UseBridges option and Vidalia's "My ISP blocks..." option is a bit confusing if you know too much about Tor :).

comment:3 in reply to:  2 Changed 8 years ago by arma

Replying to anonym:

E.g. it is overloaded as an option for setconf TunnelDirConns to 1 in older Tors that had it disabled by default; Vidalia will only setconf UseBridges to 1 if there was at least one bridge added as well. Imho the lack of one-to-one correspondence between Tor's UseBridges option and Vidalia's "My ISP blocks..." option is a bit confusing if you know too much about Tor :).

Ah. Yes, ok. But Tors have used begindir for directory conns by default since the beginning of the Tor 0.2.1.x tree. To be clearer, there are no functional Tors anymore that care about that distinction.

So it is time both to fix what has turned into a bug, and to update that help text.

comment:4 Changed 8 years ago by krkhan

  • Fix #4290 Give an error if bridges option is checked and none are specified.

comment:5 Changed 8 years ago by chiiph

Resolution: fixed
Status: newclosed

krkhan's fix was merged. Thanks, and sorry for the million years of delay.

Note: See TracTickets for help on using tickets.