Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4309 closed defect (fixed)

fingerprint example in man page is mangled

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

   ExcludeNodes SlowServer, $    EFFFFFFFFFFFFFFF, \{cc}, 255.254.0.0/8) +

I feel like I'm playing one of those "what's wrong with this picture" games.

A) Where did those spaces in the fingerprint come from? Looks like commit a330cdc6f.
B) The fingerprint doesn't have enough hexes.
C) Did I miss any?

Also, if we keep the $ it would be good to add a hint in about how your shell will probably mangle the $ if you put it on the commandline, e.g.

+ +
+    Finally, note that if you specify a fingerprint on the commandline,
+    you will need to escape the dollar sign or your shell will likely
+    mangle it.

But that said, fingerprints aren't confusable with nicknames. Should we start dropping the $ more thoroughly?

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by arma

Status: newneeds_review

See bug4309 in my arma. To be applied to maint-0.2.2.

The only controversial part is that I dropped the dollar sign entirely.

comment:2 Changed 8 years ago by nickm

arma, you are your own arma. Your repo is also your repo. When you call it 'my arma', it makes me think of smurf talk, and distracts me every time.

That said, branch bug4309 in arma's arma looks arma to me. Feel free to arma it into the official arma.

comment:3 Changed 8 years ago by arma

Resolution: fixed
Status: needs_reviewclosed

Merged.

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.