Opened 8 years ago

Last modified 2 years ago

#4320 new defect

Audit functions called during options_act_reversible()

Reported by: Sebastian Owned by:
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: audit tor-client reliability torrc configuration
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:

Description

While reviewing #4196, I wondered if it is actually safe to call parse_client_ports() from inside options_act_reversible(), because parse_client_ports() with its second argument set to 0 has a side effect. This shouldn't be allowed during options_act_reversible(), because we can't undo that change in the case of an error.

I suspect other issues like this may also exist. We should check to make sure all the functions don't modify state in a way we can't undo, or change the logic behind options_act_reversible() generally.

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by nickm

Keywords: audit added

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:5 Changed 2 years ago by nickm

Keywords: reliability torrc configuration added
Priority: MediumHigh
Severity: Normal

comment:6 Changed 2 years ago by nickm

Points: 2
Note: See TracTickets for help on using tickets.