Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#4323 closed enhancement (implemented)

Implement proposal 187 (reserve a cell type for client authorization)

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: small-feature tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We need to get this one done soon in the 0.2.3.x series to future-proof our V3 handshake for future attacks against probing attacks.

Child Tickets

Change History (11)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review
Type: defectenhancement

Please see branch "prop187" in my public repository. It is slightly tested (using Chutney), and seems to bootstrap okay, but it needs more attention, testing, and review.

comment:2 Changed 7 years ago by nickm

Keywords: small-feature added

comment:3 Changed 7 years ago by nickm

On review: I need to fix the log message in enter_v3_handshake_with_cell so it no longer refers to a versions cell. Anything else?

comment:4 Changed 7 years ago by nickm

Pushed a couple of cosmetic fixups. I hope somebody else can review this before I merge it.

comment:5 Changed 7 years ago by Sebastian

hrm, this is pretty small!

I think I have just one comment, proposal 187 needs to be edited to include the tor-spec change for the AUTHORIZE cell type (or when this gets merged we update tor-spec with the 132 right away).

When you tested with chutney, did you turn on protocol warnings and see if anything came up?

comment:6 in reply to:  5 Changed 7 years ago by nickm

Replying to Sebastian:

hrm, this is pretty small!

I think I have just one comment, proposal 187 needs to be edited to include the tor-spec change for the AUTHORIZE cell type (or when this gets merged we update tor-spec with the 132 right away).

Right. I usually don't reserve numbers when I write proposals, since there's no telling what order proposals will get accepted in.

When you tested with chutney, did you turn on protocol warnings and see if anything came up?

Protocol warnings were on (they're on by default in the default Chutney template); I don't think anything came up. I'll try again before I merge.

comment:7 Changed 7 years ago by Sebastian

ok cool. I also didn't manage to find any protocol warnings actually trigger.

comment:8 Changed 7 years ago by nickm

Tried again in a mixed 0.2.3 HEAD / 0.2.2 / prop187 chutney network. No warnings; stuff bootstrapped okay.

comment:9 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Okay, merging this at last. I hope it's right!

comment:10 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:11 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.