Implement proposal 187 (reserve a cell type for client authorization)

We need to get this one done soon in the 0.2.3.x series to future-proof our V3 handshake for future attacks against probing attacks.

changed milestone to %Tor: 0.2.3.x-final

added component::core tor/tor milestone::Tor: 0.2.3.x-final priority::medium resolution::implemented small-feature status::closed tor-relay type::enhancement labels

Please see branch "prop187" in my public repository. It is slightly tested (using Chutney), and seems to bootstrap okay, but it needs more attention, testing, and review.

Trac:
Type: defect to enhancement
Status: new to needs_review

Trac:
Keywords: N/A deleted, small-feature added

On review: I need to fix the log message in enter_v3_handshake_with_cell so it no longer refers to a versions cell. Anything else?

Pushed a couple of cosmetic fixups. I hope somebody else can review this before I merge it.

hrm, this is pretty small!

I think I have just one comment, proposal 187 needs to be edited to include the tor-spec change for the AUTHORIZE cell type (or when this gets merged we update tor-spec with the 132 right away).

When you tested with chutney, did you turn on protocol warnings and see if anything came up?

Replying to Sebastian:

hrm, this is pretty small!

I think I have just one comment, proposal 187 needs to be edited to include the tor-spec change for the AUTHORIZE cell type (or when this gets merged we update tor-spec with the 132 right away).

Right. I usually don't reserve numbers when I write proposals, since there's no telling what order proposals will get accepted in.

When you tested with chutney, did you turn on protocol warnings and see if anything came up?

Protocol warnings were on (they're on by default in the default Chutney template); I don't think anything came up. I'll try again before I merge.

ok cool. I also didn't manage to find any protocol warnings actually trigger.

Tried again in a mixed 0.2.3 HEAD / 0.2.2 / prop187 chutney network. No warnings; stuff bootstrapped okay.

Okay, merging this at last. I hope it's right!

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

Trac:
Keywords: small-feature deleted, small-feature tor-relay added

Trac:
Component: Tor Relay to Tor

closed

moved to tpo/core/tor#4323 (closed)