Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4349 closed defect (fixed)

netinfo cells declare canonical address for the remote OR, not actual address of the conn

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In connection_or_send_netinfo() we write

  /* Their address. */
  out = cell.payload + 4;
  len = append_address_to_payload(out, &conn->_base.addr);

But the goal here is to say the actual address the conn came from/to, yes? If so, shouldn't it be conn->real_addr?

Reported by "troll_un".

Targeting this one on 0.2.2 since when we eventually start using the contents of netinfo cells, we'll wish everybody had the fix.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

Rationale seems right to me. I did a branch as "bug4349_022" in my public repo. Should be trivial. Please review anyway?

comment:2 Changed 8 years ago by Sebastian

Yup, when reading the spec it does sound like this is the right fix.

comment:3 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay, merging.

comment:4 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:5 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.