Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#4353 closed defect (fixed)

Tor clients without geoip DB log that they are configured to collect stats

Reported by: Sebastian Owned by:
Priority: High Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

this is confusing, and might provoke some "OMG I AM A CLIENT WHAT KIND OF STATS ARE YOU COLLECTING" arguments (two people on #tor asked about this and one on the blog, now I know how they learned about stats stuff).

probably a patch like this:

diff --git a/src/or/config.c b/src/or/config.c
index ca4e71c..01d4036 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -1410,8 +1410,9 @@ options_act(or_options_t *old_options)
     tor_free(actual_fname);
   }
 
-  if (options->CellStatistics || options->DirReqStatistics ||
-      options->EntryStatistics || options->ExitPortStatistics) {
+  if (server_mode(options) &&
+      (options->CellStatistics || options->DirReqStatistics ||
+       options->EntryStatistics || options->ExitPortStatistics)) {
     time_t now = time(NULL);
     int print_notice = 0;
     if ((!old_options || !old_options->CellStatistics) &&

or something would fix it, but I need to look closer at it.

Child Tickets

Change History (10)

comment:1 Changed 9 years ago by Sebastian

Status: newneeds_review

branch bug4353

comment:2 Changed 9 years ago by arma

Looks good to me. If it had an actual commit message, I'd merge it.

comment:3 Changed 9 years ago by Sebastian

Has an actual commit msg, but not good. We'll try to write stats every 24h tho they aren't meaningful to write, etc. Needs revision

comment:4 Changed 9 years ago by arma

Status: needs_reviewassigned

Confirmed, my vanilla Tor client wrote a $datadir/stats/dirreq-stats file after 24 hours of uptime:

dirreq-stats-end 2011-10-31 23:13:44 (86400 s)
dirreq-v3-ips 
dirreq-v2-ips 
dirreq-v3-reqs 
dirreq-v2-reqs 
dirreq-v3-resp ok=0,not-enough-sigs=0,unavailable=0,not-found=0,not-modified=0,busy=0
dirreq-v2-resp ok=0,unavailable=0,not-found=0,not-modified=0,busy=0
dirreq-v3-direct-dl complete=0,timeout=0,running=0
dirreq-v2-direct-dl complete=0,timeout=0,running=0
dirreq-v3-tunneled-dl complete=0,timeout=0,running=0
dirreq-v2-tunneled-dl complete=0,timeout=0,running=0

comment:5 Changed 9 years ago by arma

Milestone: Tor: 0.2.3.x-finalTor: 0.2.2.x-final
Priority: normalmajor

This bug got into 0.2.2 also, right?

comment:6 Changed 9 years ago by Sebastian

hrm. yup, it did.

comment:7 Changed 9 years ago by Sebastian

Status: assignedneeds_review

There's a better idea for a fix in bug4353_v2.

comment:8 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks okay to me. Merging!

comment:9 Changed 8 years ago by nickm

Keywords: tor-client added

comment:10 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.