Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4357 closed defect (implemented)

small patch to remove absolute path from contrib/package_nsis-mingw.sh

Reported by: erinn Owned by:
Priority: Medium Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'd like to have the absolute path to makensis.exe removed so I can automate package building. I based my branch(let) on maint-2.2 and would like the change applied to all branches of tor. I also added a changes file. Branch is here:

https://gitweb.torproject.org/erinn/tor.git/shortlog/refs/heads/win-bundle-fix

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by erinn

Status: newneeds_review

comment:2 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

I've got no objection.

For future reference, Roger likes the lines in the changes files to be shorter, but that's easy enough to fix up when he does the rest of the changelog.

Merged

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.