Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#4360 closed defect (fixed)

You say CERT_CELL, I say CERTS_CELL, tomato, tomatoe

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The spec spoke of CERT cells in some places and CERTS cells in others. I figured CERTS cells fit best with VERSIONS cells, so went with that in the spec.

Now the code needs to change too. Should be no troubles to switch since the rest of the world doesn't care what one Tor's code calls cell 129.

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by arma

Status: newneeds_review

See my bug4360 branch. It will still need a changes file, if we decide this in indeed a thing we want to do.

comment:2 Changed 9 years ago by nickm

The cell can hold more than one cert, so CERTS is probably better, but either one is fine by me.

IOW, your patch looks fine. Feel free to apply

comment:3 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Or I could do it. Merging

comment:4 Changed 8 years ago by nickm

Keywords: tor-relay added

comment:5 Changed 8 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.