Opened 8 years ago

Last modified 4 weeks ago

#4374 needs_revision enhancement

If you explicitly specify a geoip file and it's not there, shouldn't Tor fail?

Reported by: arma Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client, geoip, startup, configuration, 041-deferred-20190530
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

$ src/or/tor geoipfile /path/not/here

results in this subtle line in my logs

Nov 01 06:47:50.000 [info] geoip_load_file(): Failed to open GEOIP file /path/not/here.

and no other troubles. That's probably not what we expected.

I expect this is messy to fix due to the crazy "<default>" default that we have in config.c.

Bug found by Sebastian.

Child Tickets

Attachments (1)

improve-geoip-warning.patch (437 bytes) - added by cypherpunks 3 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by nickm

I've got a sad hunch that this change would break a lot of 3rd party packages. Could be wrong, though.

comment:2 Changed 8 years ago by Sebastian

We'd basically need a way to detect whether the geoipfile option was actually set in the torrc/command line options, because otherwise you couldn't run Tor without a geoip install. That's a big hack...

The other idea would be to change the default for geoipfile to point to nothing, and you have to set the option to get the file. That's also not ideal.

Conceivably we could get away with doing nothing and adding some "download geoip db file every now and then" functionality on a post-0.2.3.x timeframe

comment:3 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:6 Changed 2 years ago by nickm

Keywords: geoip startup configuration added
Priority: MediumVery Low
Severity: Normal
Type: defectenhancement

I'm tempted to call this wontfix.

Changed 3 months ago by cypherpunks

Attachment: improve-geoip-warning.patch added

comment:7 Changed 3 months ago by teor

Milestone: Tor: unspecifiedTor: 0.4.1.x-final
Status: newneeds_revision

Thanks, that's a useful patch.

But it's only useful for systems with tor installed through a package manager.

What is someone is using an app on mobile, macOS, or Windows?
Or a snap package on Ubuntu?

comment:8 Changed 4 weeks ago by nickm

Keywords: 041-deferred-20190530 added

Marking these tickets as deferred from 041.

comment:9 Changed 4 weeks ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: unspecified
Note: See TracTickets for help on using tickets.