Opened 13 years ago

Last modified 8 years ago

#438 closed defect (Fixed)

Not checking families in all cases

Reported by: arma Owned by:
Priority: Low Milestone: post 0.2.0.x
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: arma, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


circuit_find_to_cannibalize() compares keys when deciding if two routers
are the same, but it doesn't check families.

This calls maybe for a "is r1 the same router or same family as
r2" function, plus a code audit for everywhere we compare routers
for equality and/or add them to smartlists.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (3)

comment:1 Changed 13 years ago by nickm

I've added the function and a call to that function in circuit_find_to_cannibalize, in r11886.

The audit still needs to happen.

comment:2 Changed 12 years ago by nickm

flyspray2trac: bug closed.
fixed ages ago, I believe.

comment:3 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.