Opened 12 years ago

Last modified 7 years ago

#440 closed defect (Fixed)

Guard nodes not weighted by bandwidth

Reported by: mikeperry Owned by:
Priority: High Milestone:
Component: Core Tor/Tor Version: 0.1.2.14
Severity: Keywords:
Cc: mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor clients are currently selecting guard nodes uniformly. The add_an_entry_guard call passes in
a NULL state to choose_good_entry_server, which causes it to call router_choose_random_node with
need_capacity=0.

I marked severity as High because this is obviously screwing with load balancing of the network
and probably has a large negative impact on user experience. Also, a backport of the fix is
essential since it really won't have any effect until most clients start using it.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (3)

comment:1 Changed 12 years ago by nickm

Fixed in r10493. I've changed router_choose_random_node() to choose based on bandwidth if need_capacity is set,
_or_ if need_guard is set. That should be sufficient.

comment:2 Changed 12 years ago by nickm

flyspray2trac: bug closed.

comment:3 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.