Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4400 closed enhancement (implemented)

There should be a `make version`.

Reported by: katmagic Owned by: katmagic
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: make tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It's difficult to tell what version master is, and checking configure.in every time is cumbersome. There should be a make task to do this. I have a patch available at in the make_version branch of git://github.com/katmagic/tor.git .

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by nickm

You shouldn't need that kind of grepping (and also it will break when somebody tries to build Tor from outside the source tree). Instead maybe autoconf's substitution feature and just say: "echo @VERSION@" ?

Also, this needs a changes/ file.

comment:2 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-final
Status: newneeds_review

comment:3 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Tried a simple implementation of that idea in 916aa8022d8bafa, merged in master. Let me know how it works.

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.