Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4424 closed defect (fixed)

rend_client_any_intro_points_usable leaks an extend_info_t

Reported by: rransom Owned by: rransom
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-hs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

rend_client_get_random_intro_impl returns a pointer to a newly allocated extend_info_t, which rend_client_any_intro_points_usable drops on the floor.

Introduced in commit 748350ace11fa55758fb8bafe5e5556867dd9c23 (0.2.2.25-alpha), when rend_client_any_intro_points_usable was added.

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by rransom

Status: newneeds_review

See bug4424 ( https://git.torproject.org/rransom/tor.git bug4424 ) for a fix.

comment:2 Changed 8 years ago by nickm

Looks good except that that's not our usual style. By convention, Tor's foo_free functions always test their argument and do nothing when it is NULL. I'll remove the extra "if" here.

comment:3 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

comment:4 Changed 8 years ago by rransom

Oops. frosty_un didn't find this one.

comment:5 Changed 8 years ago by nickm

Okay, editing the changes file.

comment:6 Changed 7 years ago by nickm

Keywords: tor-hs added

comment:7 Changed 7 years ago by nickm

Component: Tor Hidden ServicesTor
Note: See TracTickets for help on using tickets.