Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4426 closed defect (fixed)

"[warn] Hidden service with no ports configured; ignoring." should print HiddenServiceDir

Reported by: rransom Owned by: rransom
Priority: Very Low Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We just had a user in #tor ask for help configuring a hidden service. He/she/it was using Windows, and had put an extra backslash at the end of the HiddenServiceDir line; Tor interpreted this as meaning that that option was continued on the next line.

If we included the HiddenServiceDir in that log line, (a) users with many HSes would have less trouble finding their mistake, and (b) users who make a trailing-backslash mistake (or the people whom they ask for help) will be able to figure out their problem more quickly.

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by rransom

Status: newneeds_review

See bug4426 ( https://git.torproject.org/rransom/tor.git bug4426 ) for a fix on maint-0.2.2.

comment:2 Changed 8 years ago by rransom

Priority: normaltrivial

comment:3 Changed 8 years ago by nickm

Shall we consider these directories to be sensitive info, or just trust that nobody will send us logs saying "Hidden service (/home/lets_expose_the_mafia/hsdir) with no ports configured" ? I think it's okay to merge this patch as-is otherwise, but we should actually think about this one.

comment:4 in reply to:  3 Changed 8 years ago by rransom

Replying to nickm:

Shall we consider these directories to be sensitive info, or just trust that nobody will send us logs saying "Hidden service (/home/lets_expose_the_mafia/hsdir) with no ports configured" ? I think it's okay to merge this patch as-is otherwise, but we should actually think about this one.

We already log HiddenServiceDir if a user specifies the same directory twice. This change should decrease the number of people who need to send either their logs or their torrcs to us in order to get help with hidden service configuration problems.

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay; sounds compelling enough to me. Let's merge it.

comment:6 Changed 7 years ago by nickm

Keywords: tor-client added

comment:7 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.