Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4433 closed defect (fixed)

Return value bug in tor_addr_to_PTR_name

Reported by: 4ZM Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Function return value semantics differed between IPv4 and IPv6.

Fix available @ https://github.com/4ZM/Tor
Branch: topic/test/address
Commit: 00f87933c451cc82bdc4ab9dbd4597c93a7cee63

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by 4ZM

Status: newneeds_review

comment:2 Changed 8 years ago by nickm

Looks mostly good!

I'd be a little more comfortable if the IPv6 address tested were not simply 8000:: -- that's enough of a special form that it makes me a little nervous about the correctness of other cases. How about 8000::abcd ?

On the documentation: "Return the number of chars printed" isn't correct; no characters are printed by this function. Instead, something "return the number of characters written to <b>out</b>'" would be more accurate.

Quick git note: this isn't mergeable as-is, since it includes a re-merge of master into the branch, and also includes the common_misc branch, and also includes your #4434 fix. Generally, it's best to avoid unnecessary back-merges from a main branch into a topic branch , and to have each topic branch do only one thing so they can be merged independently.

comment:3 Changed 8 years ago by 4ZM

The suggestions have been implemented and the git repo history has been cleaned up.

Get new version from topic/test/4433_address @ https://github.com/4ZM/Tor

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merging; thanks!

comment:5 Changed 7 years ago by nickm

Keywords: tor-client added

comment:6 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.