Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4437 closed defect (fixed)

Compile warnings when using --disable-threads

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When using --disable-threads to compile tor, this warning happens on recent GCCs:

log.c:99: error: 'log_mutex' defined but not used

I'm aiming this for 0.2.2.x, but if people feel better about only fixing this in master I'm ok too. The merge is conflict-free.

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

See branch bug4437 in my repo for a fix

comment:2 Changed 8 years ago by nickm

I don't like the definition of STMT_VOID -- for some possible arguments, it evaluates the argument, when really we want the
argument to only "count as" used. So maybe a better definition would be something like "while (0) { (void)(m); }" ?

comment:3 Changed 8 years ago by Sebastian

Yes, that does look better, thanks for the suggestion. Pushed an update.

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged it; thanks!

comment:5 Changed 7 years ago by nickm

Keywords: tor-client added

comment:6 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.