Torbutton always reset SOCKS port to 9050

Wherever Torbutton is set to use recommended settings or not, the SOCKS port is always reset to 9050, or the value of the environment variable TOR_SOCKS_PORT. The same issue affects the SOCKS host.

added component::applications/torbutton priority::medium resolution::worksforme severity::normal status::closed type::defect version::torbutton 1.4.4 labels

Trac:
0001-Bug-4453-Set-SOCKS-port-and-host-only-with-recommend.patch

Possible fix against current master (7c94dc6f635)

Trac:
Status: new to needs_review

Did you test this in both TBB and Iceweasel? I suspect if you tested it in TBB, it will break after you open a 2nd new window, because it will reset the SOCKS port to 9050.

The problem is that the TOR_SOCKS_PORT is not used in torbutton_init_prefs().. torbutton_init_prefs() is called on every new window (yes, this is somewhat dumb, but it is a relic of old code).

Trac:
Status: needs_review to assigned
Owner: mikeperry to lunar

I had not tested it with TBB. My bad.

Here comes another version. Looks like it works for both now…

Trac:
0001-Bug-4453-Set-SOCKS-port-and-host-only-with-recommend_v2.patch

Trac:
Status: assigned to needs_review

Merged. Thanks!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

After experimenting with using TorBrowser connected to Linux system tor-daemon running with multiple SOCKSports options, I found the problem. Despite SOCKSport is changed in TorButton to any value, TorBrowser connects to Tor only through 9050. I check it with Wireshark/Iptables.

Attempts to change values in files does not help too:

App/Firefox/defaults/profile/prefs.js:user_pref("extensions.torbutton.socks_port",9050);

App/Firefox/defaults/profile/prefs.js:user_pref("network.proxy.socks_port",9050);
Data/profile/prefs.js:user_pref("extensions.torbutton.custom.socks_port", 9050);
Data/profile/prefs.js:user_pref("extensions.torbutton.socks_port", 9050);
Data/profile/prefs.js:user_pref("network.proxy.socks_port", 9050);

Is it possible to connect to non-9050 system Tor ?

Running TorBrowsers simultaneously divided by the means of iptables in parallell X-sessions fails. All TorBrowsers wants to works with localhost only through 9050 in the case non-TBB (system) tor.

'"Transparent Torification"' option in TorButton without local proxy doesn't works too.

TorButton 1.4.6 / tor-browser-gnu-linux-x86_64-2.2.37-1-dev-en-US.

Trac:
Username: unknown
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Status: reopened to assigned
Owner: lunar to N/A

Set all open tickets without a severity to "Normal"

Trac:
Severity: N/A to Normal

Mark all tickets that are assigned to nobody as "new".

Trac:
Status: assigned to new

I think this works now with Torbutton and TorLauncher.

Trac:
Reviewer: N/A to N/A
Sponsor: N/A to N/A
Resolution: N/A to worksforme
Status: new to closed

closed

mentioned in issue #4551 (closed)