Opened 9 years ago

Closed 9 years ago

#4462 closed defect (duplicate)

TBB tries to 'restore session' if Firefox crashed last time; then it exits when I click restore; also, isn't remembering session state dangerous?

Reported by: arma Owned by: mikeperry
Priority: Medium Milestone: TorBrowserBundle 2.2.x-stable
Component: TorBrowserButton Version:
Severity: Keywords:
Cc: mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Start your TBB. Load something in Firefox. Then kill -9 the firefox process. Exit Vidalia.

Start TBB again. When it launches Firefox, the Firefox window says "Well, this is embarrassing." and wants to restore your session.

When I click 'restore session', the window disappears and that's it. No more browser for me. (When the window disappears, I think Vidalia concludes that Firefox has exited. Back when TBB had the "close everything else when Firefox closes" behavior, my Vidalia would shut down too when I clicked on 'restore session'.)

Shouldn't Torbutton be disabling whatever writes my session state to disk?

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by arma

Cc: mikeperry added

Cc'ing mikeperry since this might be more rightly a Torbutton bug. Or maybe it should be in 'tor browser' component? Please move as appropriate.

comment:2 Changed 9 years ago by mikeperry

Component: Tor bundles/installationTorBrowserButton
Owner: changed from erinn to mikeperry

Hrmm, yes, this is bad behavior. We should not be displaying this page at all in the default case. I think we can do this in Torbutton.. Maybe.

Note that we should be also preventing this thing from actually saving anything to restore using a new Firefox API that Mozilla created for FF4, and that may be why it just exits when you try to restore your blank session.. However, there may be an odd race condition in that API or how we use it as well. I've noticed on like 1 restart out of 20 that there's a stray url still there (#4430).

We use the filter API because we need the session store to be partially active to preserve features like "Undo closed tab", which don't require disk access.

comment:3 Changed 9 years ago by mikeperry

Milestone: TorBrowserBundle 2.2.x-stable

comment:4 Changed 9 years ago by keb

i just encountered this too. seems to me the session restore "feature" should be completely disabled in the customized TBB Firefox, as it will mostly try to restore a session using a different exit node.

comment:5 Changed 9 years ago by mikeperry

Resolution: duplicate
Status: newclosed

Dupping to #4430.

Note: See TracTickets for help on using tickets.