Opened 8 years ago

Closed 8 years ago

#4470 closed defect (fixed)

Always build Tor with warnings enabled

Reported by: Sebastian Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For a few releases, Tor had compile warnings on Windows. We should make sure to always build with --enable-gcc-warnings for all our builds and only disable that temporarily if we have a good reason for it (for example, backports to oldstable etc).

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

branch bug4470 in my repo

comment:2 Changed 8 years ago by Sebastian

(for torbrowser, that is. Not the normal vidalia bundle builds, they'll still need to be done afterwards)

comment:3 Changed 8 years ago by erinn

Sebastian,

Does your branch have fixes for two different bugs? There is the --enable-gcc-warnings fix as well as a commit for removing startup messages. They seem unrelated, and the startup messages seems intended for #4093.

comment:4 Changed 8 years ago by Sebastian

hrm, yeah. Please just cherry-pick the commit about gcc-warnings? Sorry!

comment:5 Changed 8 years ago by erinn

Resolution: fixed
Status: needs_reviewclosed

Fixed in the latest tbbs. Closing.

Note: See TracTickets for help on using tickets.