Opened 8 years ago

Closed 5 years ago

#4476 closed defect (duplicate)

Our build scripts have ceased being idempotent

Reported by: pde Owned by: pde
Priority: Very Low Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: dw188, graffatcolmingov@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently the HTTPS Everywhere build scripts compute a zip file over a tree that contains one or several variable timetstamp(s) in it.  That makes the hashes of .xpi files non-constant, which is an unsatisfactory state of affairs!

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by dw188

Cc: dw188 added

Picked this issue up at random to look at. Which is the desired behavior:

  1. Two developers clone same repository at same revision. When they each build, the .xpi has the same hash.
  2. A single developer clones repository. They build and get a .xpi with some hash. If they build again, they get a .xpi with the same hash.

I think (2) must be the desired behavior, because when you clone a repository, all the files have the times of when you cloned. (1) would imply (2).

comment:2 Changed 8 years ago by pde

  1. Is the desired behaviour.  If necessary, the file timestamps can be manually set to the time the tag was created during the build process.

comment:3 Changed 8 years ago by pde

That sentence wasn't very clear:  Let me try again ;)  When given a specific tag to build, our build scripts perform a checkout of that tag in a build subdirectory.  If necessary, that entire subdirectory can have its timestamps set to the time the tag was created.

comment:4 Changed 8 years ago by graffatcolmingov

Cc: graffatcolmingov@… added

comment:5 Changed 7 years ago by pde

Priority: normaltrivial

We have worked around this in our release scripts, so it's less of a problem than it was previously.

comment:6 Changed 5 years ago by jsha

Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.