Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4516 closed enhancement (implemented)

Disable send/receive buffers when using IOCP.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: windows iocp bufferevents tor-relay
Cc: Actual Points:
Parent ID: #3561 Points:
Reviewer: Sponsor:

Description

To get much of the benefit from IOCP, we need to disable all kernel-space buffers on sockets, and have the winsock stack read and write directly from pre-allocated userspace buffers.

This change is easy enough to do. The harder part will be looking for related bugs once it's turned on.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-final
Status: newneeds_review

This is "feature4516" in my public repository.

I'm not promising that it works, mind you, but it's controlled by an option so it's easy to turn it off when it breaks. I say we should merge it soon, and try testing it in the next windows-bufferevents-iocp package.

comment:2 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

It's off-by-default, so "what harm could it do"? Merging as threatened.

comment:3 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:4 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.