Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4526 closed enhancement (implemented)

Use OpenSSL 1.0.0's counter-mode code

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

OpenSSL 1.0.0 has a counter-mode implementation that seems faster than ours. Let's do benchmarks to make sure, and use it (if possible). If not, let's clone it or at least adopt its good ideas.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

See commit 236219f0972e44 in my branch more_aes_hackery. (The branch also has a fix for #4525 .)

On an unaccelerated platform, this seems to help our AES-CTR performance by about 7%; it should probably make an even bigger difference with AES acceleration turned on.

(Yes, that is *total* AES-CTR performance, including both the AES and the CTR.)

comment:2 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Tested more, cleaned up, squashed some commeits. This (and #4525) are an even bigger win on less beefy platforms. On my cute little atom laptop, they make the cell_aes benchmark run 15-20% faster.

Merging as threatened.

comment:3 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:4 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.