Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4530 closed defect (fixed)

tor_addr_port_lookup(): addr_out filled with random bytes if transient failure

Reported by: troll_un Owned by:
Priority: High Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

tor_addr_port_lookup() wrongly detect errors of tor_addr_lookup().

if (tor_addr_lookup(tmp, AF_UNSPEC, &addr) < 0)

tor_addr_lookup() returns non negative (return 1) on transient failure, that leaves addr as non inited. tor_addr_copy(addr_out, &addr) filling addr_out with random bytes.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Milestone: Tor: 0.2.2.x-final
Priority: normalmajor

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: newclosed

Should be fixed in b7015603fa014c91056fa46cb012976a9e166cd3.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.