compat.h: tor_socket_t defined as intptr_t instead native SOCKET (Windows)

Windows (32,64,128,256) has type SOCKET for sockets. Tor could use SOCKET instead decoding OS headers and redefine socket type when Window128 happens.

Trac:
Username: troll_un

changed milestone to %Tor: unspecified

added Windows component::core tor/tor easy milestone::Tor: unspecified priority::very low reporter::troll_un resolution::wontfix severity::normal status::closed tor-client type::defect labels

Trac:
Milestone: N/A to Tor: 0.2.3.x-final
Priority: normal to major

So the risky thing here is that SOCKET is defined as u_int on win32 and UINT_PTR on win64. If we make this change, we will have tor_socket_t be unsigned on windows and signed everywhere else. Every place that currently checks for sockets being < 0 will instead have to use the SOCKET_OK macro.

That said, I'm okay doing this on 0.2.3.x if we can seriously audit everything that looks at a socket for correctness.

At this point the benefit isn't high enough to do the intptr -> socket transition in 0.2.3.x, and I'm not sure it will be. (If win128 makes SOCKET a 128-bit type, it'll probably make intptr_t 128-bit too, and vice versa. But just in case, checking the type size at compile time might be reasonable.)

Still, there are some more places we should be using the macros we have. See branch "bug4533_part1" in my public repo, which also adds a runtime test

Trac:
Status: new to needs_review

< wanoskarnet> "(unsigned)(s) != INVALID_SOCKET" is never false for win64. SOCKET is unsigned and sizeof(SOCKET) is 8 bytes and INVALID_SOCKET defined as (SOCKET)(-1) so (unsigned)(intptr_t)(-1) never equal (SOCKET)(-1). 00000000FFFFFFFF != FFFFFFFFFFFFFFFF

Separate bug; fix in bug4533_part2 to be applied to 0.2.2.x. Needs review.

Merged those branches. Throwing any intptr->SOCKET transition into unspecified.

Trac:
Milestone: Tor: 0.2.3.x-final to Tor: unspecified

Trac:
Keywords: Windows easy deleted, Windows easy tor-client added

Trac:
Component: Tor Client to Tor

Inclined to close this as wontfix.

Trac:
Severity: N/A to Normal
Sponsor: N/A to N/A
Priority: High to Very Low

Trac:
Status: needs_review to closed
Resolution: N/A to wontfix
Reviewer: N/A to N/A

closed

mentioned in issue #4534 (moved)

mentioned in issue #4946 (moved)

moved to tpo/core/tor#4533 (closed)

mentioned in issue tpo/core/tor#4946 (closed)