Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4578 closed defect (implemented)

proposal 178 stuff

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

prop178 in my torspec repo, branch safer_params in my tor repo, my tor-dev post

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

comment:2 Changed 8 years ago by nickm

Merged the spec changes.

The code looks okay, except I think you're leaking the output of dirvote_compute_params in the new tests in test_dir_param_voting.

Could I have a fix for that (and a patch to dir-spec.txt)?

comment:3 Changed 8 years ago by Sebastian

Ugh. No, the patch looks horrible. Will provide updates.

comment:4 Changed 8 years ago by Sebastian

Fortunately, we have unit tests... that's how I spotted the "or equal to MIN_VOTES_FOR_PARAM" bug.

I'm also adding some more unit tests, that you may want to take or not (as an extra fixup commit).

Also updated prop178 branch in my torspec repo with the dir-spec changes.

comment:5 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Ow. That would have been ouchy.

More unit tests is IMO a definitely good idea here. Merging it all.

comment:6 Changed 7 years ago by nickm

Keywords: tor-client added

comment:7 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.