Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4604 closed defect (fixed)

load_torrc_from_disk does not set torrc_fname

Reported by: rransom Owned by: rransom
Priority: High Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

(Bugfix on the #4552 changes (not in any release); reported by koolfy.)

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by rransom

Resolution: invalid
Status: newclosed

Never mind. It looks like it does set torrc_fname.

comment:2 Changed 8 years ago by rransom

Priority: normalmajor
Resolution: invalid
Status: closedreopened

No it doesn't. It sets torrc_defaults_fname to the name of the non-defaults config file instead.

  char **fname_var = defaults_file ? &torrc_fname : &torrc_defaults_fname;

comment:3 Changed 8 years ago by rransom

Owner: changed from nickm to rransom
Status: reopenedassigned

comment:4 Changed 8 years ago by rransom

Status: assignedneeds_review

See my branch bug4604 for a fix.

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merging; thanks!

comment:6 Changed 8 years ago by nickm

Keywords: tor-client added

comment:7 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.