Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4619 closed defect (worksforme)

Find out if we need to optimise node_get_all_orports()

Reported by: ln5 Owned by: ln5
Priority: Low Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: performance tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From #3786:

If node_get_all_orports() is at all near the critical path, we should think about some way to
make it faster: allocating and freeing little objects over and over can get expensive.


Would you suggest node_get_all_orports() taking a smartlist pointer as an argument? And even two
(optional) tor_addr_t pointers?

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:2 Changed 8 years ago by asn

Keywords: performance added

comment:3 Changed 8 years ago by nickm

I propose that unless this function or its callers show up a lot in profiles, we should close this ticket.

comment:4 Changed 8 years ago by nickm

Resolution: worksforme
Status: newclosed

I say we close this ticket. If the function shows up on a profile, we can optimize it; if it doesn't, we will never remember to close it.

comment:5 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:6 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.