Add GETINFO interface_address
get_interface_address6() in src/common/address.c finds out the IP address of the internet-facing interface. This can be useful to controllers like arm which can use the IP address for setting up port-forwarding.
Activity
From src/common/address.c:
/** Set *<b>addr</b> to the IP address (if any) of whatever interface * connects to the Internet. This address should only be used in checking * whether our address has changed. Return 0 on success, -1 on failure. */ int get_interface_address6(int severity, sa_family_t family, tor_addr_t *addr)I'm not exposing this function to the control port if its result ‘should only be used in checking whether our address has changed’.
Tor appears to use the result of
get_interface_address6for purposes other than ‘checking whether our address has changed’, so the documentation comment may be wrong. Also:- If the point of this GETINFO item is to let controllers know what Tor currently thinks its address is, we should expose that piece of information to the control port. (That would be even harder for controllers to figure out on their own than what the current implementation of
get_interface_address6would return.) - Once nickm's bug1827 branch is merged, we will have OS-specific methods of finding lists of network interface addresses. Exposing all of those might be useful to a controller.
- If the goal is to help controllers set up port forwarding for Tor, perhaps we should expose whatever information Tor passes to
tor-fw-helperto the control port. - Do
GETINFO net/listeners/orandGETINFO net/listeners/dirhelp here?
Trac:
Status: closed to reopened
Resolution: wontfix to N/A
Milestone: N/A to Tor: 0.2.3.x-final- If the point of this GETINFO item is to let controllers know what Tor currently thinks its address is, we should expose that piece of information to the control port. (That would be even harder for controllers to figure out on their own than what the current implementation of
Replying to rransom:
Tor appears to use the result of
get_interface_address6for purposes other than ‘checking whether our address has changed’, so the documentation comment may be wrong. Also:- If the point of this GETINFO item is to let controllers know what Tor currently thinks its address is, we should expose that piece of information to the control port. (That would be even harder for controllers to figure out on their own than what the current implementation of
get_interface_address6would return.)
I think rather that this is a bug in how we use the function currently, it was never intended for something that it later got used for.
- If the point of this GETINFO item is to let controllers know what Tor currently thinks its address is, we should expose that piece of information to the control port. (That would be even harder for controllers to figure out on their own than what the current implementation of
Tor already responds to
GETINFO address, which outputs address retrieved fromrouter_pick_published_address(), but this may not be an IP address of network interface used by Tor instance if it is running behind NAT.Should
GETINFO address/ipv4andGETINFO address/ipv6return address fromget_interface_address6()withfamilyparameter beingAF_INETandAF_INET6respectively? Should we leave implementation ofGETINFO addressas-is, in order to leave opportunity to retrieve published (guessed?) address available to controller?moved to tpo/core/tor#4636 (closed)
