Opened 8 years ago

Closed 2 years ago

#4644 closed defect (worksforme)

tor_addr_is_internal shows up in profiles -- can we fix that?

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: performance, tor-dirauth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

tor_addr_is_internal is in each of the three profiles on #4626. It shouldn't be there.

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by asn

Keywords: performance added

comment:2 Changed 7 years ago by nickm

The tor_addr_is_internal implementation is suboptimal, but not *that* bad: if it's eating CPU, that's probably because something is calling it way too much. Knowing whether this still happens, and whether it's authority-only, will help: the profiles from #4626 were from a fairly screwy situation.

comment:3 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

We can bump this back into 0.2.3.x if it shows up in non-screwy profiles.

comment:4 Changed 7 years ago by nickm

Keywords: tor-auth added

comment:5 Changed 7 years ago by nickm

Component: Tor Directory AuthorityTor

comment:6 Changed 2 years ago by dgoulet

Keywords: tor-dirauth added; tor-auth removed

Turns out that tor-auth is for directory authority so make it clearer with tor-dirauth

comment:7 Changed 2 years ago by nickm

Resolution: worksforme
Severity: Normal
Status: newclosed

It hasn't been in recent profiles so much.

Note: See TracTickets for help on using tickets.