Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4653 closed defect (fixed)

Use SSL_state_string_long() instead of homebrewed ssl_state_to_string()

Reported by: asn Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

OpenSSL has two functions to get a string version of the SSL state,
SSL_state_string_long() and SSL_state_string().

We can use these instead of the homebrewed ssl_state_to_string() and the tortls_state.h file.

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by asn

Milestone: Tor: unspecified

comment:2 Changed 8 years ago by nickm

Keywords: easy added

Sounds like a fine idea to me; I'd take something like this in 0.2.3 if it were written.

comment:3 Changed 8 years ago by esnyder

Status: newneeds_review

Just trying to start getting my feet wet w/ tor development, this seemed like a good first bug to tackle. Change in branch at https://github.com/esnyder/tor/tree/bug4653

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Thanks, looks good to me! Merging.

comment:5 Changed 7 years ago by nickm

Keywords: tor-client added

comment:6 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.