Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#4657 closed defect (fixed)

setting myfamily on a bridge should warn (and fail?)

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-bridge
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Per http://archives.seul.org/tor/talk/Nov-2011/msg00209.html
we should do something to inform the user of his mistake if he sets myfamily on a bridge.

I'd argue for 'and fail' too, except presumably the real problem is that the user set myfamily on his public relay, and that's what ought to fail -- but it's harder for the public relay to realize this.

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:2 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.2.x-final
Status: newneeds_review

I'm going to say "warn and ignore the setting".

It's a very simple change change, so I am moving this back to 0.2.2.x.

Please review branch "bug4657"

comment:3 Changed 8 years ago by nickm

Still needs review. Leaving this in 0.2.2.x, since it is a usability issue that can result in inadvertent bridge disclosure.

comment:4 Changed 8 years ago by nickm

Milestone: Tor: 0.2.2.x-finalTor: 0.2.3.x-final
Resolution: fixed
Status: needs_reviewclosed

Still looks okay to me. Merged into 0.2.3.

comment:5 Changed 8 years ago by nickm

Keywords: tor-bridge added

comment:6 Changed 8 years ago by nickm

Component: Tor BridgeTor
Note: See TracTickets for help on using tickets.