Opened 9 years ago

Closed 7 years ago

#4677 closed defect (fixed)

master won't build without V2_HANDSHAKE_SERVER

Reported by: asn Owned by:
Priority: Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

master won't build without V2_HANDSHAKE_SERVER:

tortls.c:1525:40: error: ‘tor_tls_debug_state_callback’ undeclared (first use in this function)
tortls.c:1525:40: note: each undeclared identifier is reported only once for each function it appears in

This happens because without V2_HANDSHAKE_SERVER, tor_tls_debug_state_callback is not defined and it's not visible when tor_tls_new() tries to do:

 SSL_set_info_callback(result->ssl, tor_tls_debug_state_callback);

This bug was introduced in 410e440a8d40e556cc445a1ecc6a8ed4109434b6, and simply always defining tor_tls_debug_state_callback (and not only when V2_HANDSHAKE_SERVER`) should fix it.

Child Tickets

Attachments (1)

ticket4677.patch (5.4 KB) - added by piet 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by nickm

Keywords: easy added
Milestone: Tor: 0.2.3.x-finalTor: unspecified

We don't need to do this for 0.2.3.x, though I'd take a patch if it were obviously correct

comment:2 Changed 8 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.2.4.x-final

comment:3 Changed 8 years ago by nickm

Keywords: tor-relay added

comment:4 Changed 8 years ago by nickm

Component: Tor RelayTor

comment:5 Changed 8 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

Changed 7 years ago by piet

Attachment: ticket4677.patch added

comment:6 Changed 7 years ago by piet

Status: newneeds_review

This patch fixes it for me. tor_tls_debug_state_callback wasn't the only undeclared identifier, though.

comment:7 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks okay, except that the change to the condition on tor_tls_session_secret_cb was wrong. It needs to happen unconditionally, so that the ciphersuite detection logic that lets us use ciphers from the unrestricted list can work. (See proposal 198 for information on why that's necessary.) Merging this as-is would have turned off all the ECDHE ciphers.

Fixed in 8f9c847fbf4032a8db4802708f7e2d69a26cd3d2 and merged.

Note: See TracTickets for help on using tickets.