Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4703 closed defect (fixed)

Compilation with clang 3.0 currently fails with warnings enabled

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

First off, compilation completely fails because clang doesn't recognize the -Wnormalized=id -Woverride-init CFLAGS yet, so disable them for clang 3.0 and lower. Also then there's a false positive in crypto.c.

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

Fixes for both in branch clang-3.0-fixes in my repo

comment:2 Changed 8 years ago by nickm

I'd prefer to just disable the unsupported stuff for clang, rather than pretending that 3.1 might well get it. It might, but I'd rather add support back in when clang starts supporting it, than have to re-do this patch every time a new clang comes out. The original "let's be optimistic in case a later version supports this" idea was IMO a mistake.

Also, should the "disable the compilation flags" patch be on 0.2.2?

Also, if we're tweaking the stuff in crypto_get_stored_dynamic_dh_modulus, let's just use tor_asprinf().

comment:3 Changed 8 years ago by Sebastian

Ok, making the fixes you suggested. clang-3.0-fixes_022 and clang-3.0-fixes_master in my repo. Please merge the _022 branch into master after merging the _master branch.

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

comment:5 Changed 7 years ago by nickm

Keywords: tor-client added

comment:6 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.