Opened 8 years ago

Closed 13 months ago

#4711 closed defect (wontfix)

Vidalia Proxy settings partly loss after toggle.

Reported by: bogo Owned by: karulis
Priority: Medium Milestone: Vidalia: 0.3.x
Component: Archived/Vidalia Version: Vidalia: 0.2.12
Severity: Normal Keywords: settings, archived-closed-2018-07-04
Cc: karulis@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In Settings/Network:

While "I use a proxy to access the Internet" checked and Address/Port/Type filled with values previously.

Then uncheck "I use a proxy to access the Internet" and press OK.

Address and Type fields will empty and just Port setting still there on next check of Settings/Network/"I use a proxy to access the Internet"

Child Tickets

Attachments (3)

vidaliaproxy.png (94.3 KB) - added by bogo 8 years ago.
vidalia.patch (5.8 KB) - added by karulis 7 years ago.
patch
vidalia-alpha.diff (5.2 KB) - added by karulis 7 years ago.
diff for alpha branch

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by bogo

Attachment: vidaliaproxy.png added

comment:1 Changed 7 years ago by chiiph

Keywords: settings added; Vidalia Proxy removed
Milestone: Vidalia: 0.3.x
Version: Vidalia: 0.2.15Vidalia: 0.2.12

comment:2 Changed 7 years ago by intrigeri

In the upcoming 0.3.2 CHANGELOG, I read "Remove the proxy settings handling since we do not use it anymore.", so this bug will disappear (with the feature it affects) in 0.3.2, correct?

comment:3 Changed 7 years ago by chiiph

No, this bug is about the proxy that tor uses, not the proxy application that Vidalia used to run (which was the affected by the 0.3.2 change).

arma helped me clarifying the CHANGELOG. Here's the new changelog entry for the one you're talking about:

o Remove the ability to launch an http proxy (e.g. Polipo), since Tor

Browser Bundle does not use it anymore. In the future, perhaps
a plugin will allow users to launch external applications like
this. Fix bug 5386.

comment:4 Changed 7 years ago by karulis

Cc: karulis@… added
Owner: changed from chiiph to karulis
Status: newassigned

I have simple fix for that - we will have to add another setting value to AbstractTorSettings
(SETTING_PROXY_x).
Something like SETTING_PROXY_ENABLED that will remember if ui.chkUseProxy is checked.
Other SETTING_PROXY_x settings will be always saved/loaded.

Based on SETTING_PROXY_ENABLED we will "Apply the current network configuration settings to Tor." in NetworkSettings::apply, and enable/disable QGroupBox grpProxySettings.

That would be my first fix for vidalia so i'm not sure what the workflow is;)
Anyway i'm assigning bug to me.

Changed 7 years ago by karulis

Attachment: vidalia.patch added

patch

comment:5 Changed 7 years ago by karulis

Status: assignedneeds_review

So this is possible fix.

Disabling/enabling proxy works similarly to what is in Firefox, so I think it's pretty user friendly.

I also tried to confirm that proxy actually works(with wireshark), but someone else should also verify it.

Changed 7 years ago by karulis

Attachment: vidalia-alpha.diff added

diff for alpha branch

comment:6 Changed 7 years ago by chiiph

Status: needs_reviewneeds_revision

Even though it looks good, except for minor indentation issues, the alpha patch shouldn't set ProxyEnabled in vidalia.conf. The policy for settings handling in 0.3.2 and on is to have all tor settings live in the torrc (see setVolatileValue(), Torrc class, and related), which is problematic in a case like this one, because if you set the proxy you enable the use of it. One idea was to have a certain kind of torrc comment format, like for example, if a line looks like this:

#* HTTPProxy 127.0.0.1:1234

(note the #* comment), then that's an old value that should be set if the user enables that particular option again.

comment:7 Changed 20 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:8 Changed 13 months ago by teor

Keywords: archived-closed-2018-07-04 added
Resolution: wontfix
Status: needs_revisionclosed

Close all tickets in archived components

Note: See TracTickets for help on using tickets.