Vidalia Proxy settings partly loss after toggle.

In Settings/Network:

While "I use a proxy to access the Internet" checked and Address/Port/Type filled with values previously.

Then uncheck "I use a proxy to access the Internet" and press OK.

Address and Type fields will empty and just Port setting still there on next check of Settings/Network/"I use a proxy to access the Internet"

Trac:
Username: bogo

changed milestone to %Vidalia: 0.3.x

added archived-closed-2018-07-04 component::archived/vidalia milestone::Vidalia: 0.3.x owner::karulis priority::medium reporter::bogo resolution::wontfix settings severity::normal status::closed type::defect version::vidalia 0.2.12 labels

Trac:
Username: bogo

Trac:
Username: bogo

Trac:
Version: Vidalia: 0.2.15 to Vidalia: 0.2.12
Milestone: N/A to Vidalia: 0.3.x
Keywords: Vidalia, Proxy deleted, settings added

In the upcoming 0.3.2 CHANGELOG, I read "Remove the proxy settings handling since we do not use it anymore.", so this bug will disappear (with the feature it affects) in 0.3.2, correct?

No, this bug is about the proxy that tor uses, not the proxy application that Vidalia used to run (which was the affected by the 0.3.2 change).

arma helped me clarifying the CHANGELOG. Here's the new changelog entry for the one you're talking about: o Remove the ability to launch an http proxy (e.g. Polipo), since Tor Browser Bundle does not use it anymore. In the future, perhaps a plugin will allow users to launch external applications like this. Fix bug 5386.

I have simple fix for that - we will have to add another setting value to AbstractTorSettings (SETTING_PROXY_x). Something like SETTING_PROXY_ENABLED that will remember if ui.chkUseProxy is checked. Other SETTING_PROXY_x settings will be always saved/loaded.

Based on SETTING_PROXY_ENABLED we will "Apply the current network configuration settings to Tor." in NetworkSettings::apply, and enable/disable QGroupBox grpProxySettings.

That would be my first fix for vidalia so i'm not sure what the workflow is;) Anyway i'm assigning bug to me.

Trac:
Username: karulis
Cc: N/A to karulis@wp.pl
Owner: chiiph to karulis
Status: new to assigned

Trac:
Username: karulis

vidalia.patch

patch

Trac:
Username: karulis

So this is possible fix.

Disabling/enabling proxy works similarly to what is in Firefox, so I think it's pretty user friendly.

I also tried to confirm that proxy actually works(with wireshark), but someone else should also verify it.

Trac:
Username: karulis
Status: assigned to needs_review

Trac:
Username: karulis

vidalia-alpha.diff

diff for alpha branch

Trac:
Username: karulis

Even though it looks good, except for minor indentation issues, the alpha patch shouldn't set ProxyEnabled in vidalia.conf. The policy for settings handling in 0.3.2 and on is to have all tor settings live in the torrc (see setVolatileValue(), Torrc class, and related), which is problematic in a case like this one, because if you set the proxy you enable the use of it. One idea was to have a certain kind of torrc comment format, like for example, if a line looks like this:

#* HTTPProxy 127.0.0.1:1234

(note the #* comment), then that's an old value that should be set if the user enables that particular option again.

Trac:
Status: needs_review to needs_revision

Set all open tickets without a severity to "Normal"

Trac:
Severity: N/A to Normal

Close all tickets in archived components

Trac:
Keywords: N/A deleted, archived-closed-2018-07-04 added
Status: needs_revision to closed
Resolution: N/A to wontfix

closed