Opened 8 years ago

Closed 8 years ago

#4713 closed task (implemented)

Review new consensus-health check implementation

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics Utilities Version:
Severity: Keywords:
Cc: Sebastian, rransom Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In the past few weeks I rewrote almost the entire consensus-health check code. The download and parsing logic is now part of metrics-lib. The new code focuses mainly on two things: create an HTML output and write warnings to files.

I think the code is now ready for a review. I would very much appreciate any comments on code style, documentation fixes, refactoring suggestions, potential bugs, real bugs, etc. A patch with comments that I can work off would be great!

The code is here: https://gitweb.torproject.org/doctor.git

Thanks!

Child Tickets

Change History (2)

comment:1 Changed 8 years ago by karsten

Status: newneeds_review

comment:2 Changed 8 years ago by karsten

Resolution: implemented
Status: needs_reviewclosed

Sebastian took a brief look during the Frankfurt dev meeting and said "looks good." Other than that, I don't think there's a value in leaving this ticket open. If people want to review the code, they can still do it.

Note: See TracTickets for help on using tickets.