Opened 8 years ago

Closed 7 years ago

#4718 closed enhancement (fixed)

Perform versioncheck periodically in background

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone: TorBrowserBundle 2.2.x-stable
Component: TorBrowserButton Version:
Severity: Keywords: MikePerry201205
Cc: Actual Points: 3.5
Parent ID: Points: 3
Reviewer: Sponsor:

Description

Torbutton should perform an async XMLHTTPRequest TBB version check periodically, so that new windows show an updated Tor check status message.

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by mikeperry

Keywords: MikePerry201205 added

comment:2 Changed 7 years ago by mikeperry

Actual Points: 3
Points: 3
Resolution: fixed
Status: newclosed

This is done. We check every 12 hours. I also made the initial check async as part of this.

Will appear in 1.4.6.

comment:3 Changed 7 years ago by arma

Resolution: fixed
Status: closedreopened

Uh oh. This behavior will undermine Tor's "go dormant if the user isn't doing anything over Tor" behavior, yes?

How about we export whether Tor is dormant via the control port (#5954), and then you can change the "if (++this.update_counter > 720)" section to check the getinfo (if available) before proceeding?

comment:4 Changed 7 years ago by mikeperry

arma: Firefox has been torpedoing us for a while now and no one seems to have noticed. It already performs addon update checks every 24 hours, and safebrowsing updates at some similar frequency. Would you like me to change it from 12 to 24 in Torbutton, too?

Alternatively (or in addition?), I can launch an async request every time the user does New Identity or opens a new window. Check.tp.o is already loaded in these circumstances.

comment:6 Changed 7 years ago by mikeperry

Actual Points: 33.5
Resolution: fixed
Status: reopenedclosed

Ok, I've gone ahead and moved the async check to each New Identity and New Window invocation instead.

You might want to open another ticket for the addon updater. Not sure how we want to handle that.

Note: See TracTickets for help on using tickets.