Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4746 closed defect (fixed)

Add a header to 'keys/dynamic_dh_params'.

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: small-feature tor-relay
Cc: Actual Points:
Parent ID: #4548 Points:
Reviewer: Sponsor:

Description

keys/dynamic_dh_params currently holds the Dynamic DH parameters (#4548) of the relay, which is a base64 blob.

We should probably add a small documentation header on top of the file, so that people know what it is and why they should not touch it.

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by asn

Status: newneeds_review

Please see branch bug4746 in https://git.gitorious.org/mytor/mytor.git.

It adds the following header to the keys/dynamic_dh_params file:

# This file contains stored Diffie-Hellman parameters for future use.
# You *do not* need to edit this file.

comment:2 Changed 8 years ago by nickm

Hm. It's more usual to wrap this kind of thing in a PEM-style ----BEGIN/ -----END block. Also, we don't have any other "don't edit this" disclaimer in the keys subdir of the data directory, so I don't know that I need one here.

Has this file actually confused anyone?

comment:3 in reply to:  2 Changed 8 years ago by asn

Replying to nickm:

Hm. It's more usual to wrap this kind of thing in a PEM-style ----BEGIN/ -----END block. Also, we don't have any other "don't edit this" disclaimer in the keys subdir of the data directory, so I don't know that I need one here.

Has this file actually confused anyone?

I think Roger Dingledine got confused by this file some days ago, and he suggested adding a header. I think it doesn't hurt, and it might even help people who are lost in their keys directory (I know I would appreciate the header if I didn't know what the file was for.).

I don't have any preferences for the header string either. If we end up keeping the header, please change the message to whatever you think is better (or suggest something and I will change it).

Finally, notice that the branch will not replace the current keys/dynamic_dh_params, with a keys/dynamic_dh_params with headers. So, with this branch, relays who have already generated their dynamic DH parameters, will not have headers in their files.

comment:4 Changed 8 years ago by nickm

Keywords: small-feature added

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged with a changes file and some whitespace tweaks.

comment:6 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:7 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.