getsockname in connection_handle_listener_read should be getpeername

Noticed while reviewing #4745 (moved): it seems that the getsockname added in 70f3b3ef8677 should have been a getpeername.

changed milestone to %Tor: 0.2.2.x-final

added component::core tor/tor milestone::Tor: 0.2.2.x-final priority::medium resolution::fixed status::closed tor-relay type::defect labels

See the first commit in branch "bug4745_4747" in my public repository.

Also, I have audited all the other uses of getsockname(), and haven't found any other mistakes.

Trac:
Status: new to needs_review

< wanoskarnet> Every new bug (#4747) is the wrongly closed old ticket (#1240).
...
< asn> wanoskarnet: nickm: the question is, can anything bad happen when filling 'remote' with the local address at that point? (#4747)
< wanoskarnet> only spoofed logs. unless some comlicated nat configuration the it's leaves unlimited speed for link with poofed addr.
< asn> If the connection can survive with the local address in conn->addr, connection_is_rate_limited() will indeed not consider it.

As wanoskarnet pointed out, 'r1eo' in #1240 (moved) was many months ahead of us.

'r1eo' gets 100 points for noticing this bug first. And if the "closing by request" comment afterwards is accurate, 'r1eo' then immediately loses 1000 points again.

See #1240 (moved) instead.

Bug #1240 (moved) is now fixed, rendering this one irrelevant.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Keywords: N/A deleted, tor-relay added

Trac:
Component: Tor Relay to Tor

closed

moved to tpo/core/tor#4747 (closed)