Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4786 closed defect (fixed)

Never downgrade cells from RELAY_EARLY to RELAY.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

To support v1 connections, we had a rule that any RELAY_EARLY cell sent over them had to be downgraded and sent as RELAY. Since 0.2.0.x is supposed to be dead, we can remove this. It will be needed to make #4339 work.

See #4339 for related issues. Based on a comment by wanoskarnet.

Child Tickets

Change History (9)

comment:1 Changed 8 years ago by arma

Sounds good to me.

To paraphrase, this plan is to let relay-early cells survive intact on v1 connections, rather than changing them to relay cells which would now make the circuit get torn down if it includes an upgraded relay?

Is this a change that should go into 0.2.2, even if the other prop110 changes are going into 0.2.3?

comment:2 Changed 8 years ago by nickm

Status: newneeds_review

See branch bug4786 in my public repository. I think this can go in 0.2.2.

comment:3 Changed 8 years ago by arma

looks good to me.

bonus points if we note what version that code went in. looks like it was 0.2.0.12-alpha.

comment:4 Changed 8 years ago by arma

is this the sort of thing we should merge into maint-0.2.1 in case there's another 0.2.1 one day? or will we attempt to abandon 0.2.1 without any further releases?

comment:5 Changed 8 years ago by nickm

Hrm. It isn't the severity of a thing I'd ordinarily call necessary for 0.2.1.x, but I'm okay with doing it on 0.2.1.x in case you think that's in order.

We have said,

The Tor 0.2.1.x series is also approaching its end-of-life: it will no
longer receive support after some time in early 2012.

Which implies to me that 0.2.1.x isn't dead yet.

comment:6 Changed 8 years ago by rransom

See my bug4786 branch for a fixup for the changes/ file. Other than that, looks good.

comment:7 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Squashed, rebased onto 0.2.1 (as branch bug4786_021), merging there and forward.

comment:8 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:9 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.