TBB does not like the standard theme on Windows XP, Vista, and 7
The latest TBB does not like the standard theme on Windows XP, Vista, and 7. The minimize, maximize, and close buttons in the top right corner are not visible. And the box displaying certificate information is transparent and not solid. See the attached screenshot.
A temporary fix is to change to the classic Windows theme.
Activity
Adding comment from phobos; "Five people have called today to report the new 0.2.2.35-4 TBB in Win7 doesn't have the normal window management buttons (min, max, close) displaying. The buttons do work, if you click in the right spot, but the display is a big black bar. So far, this is happening on Win7 32bit and 64bit."
Missing mozconfig seemed to be the problem. We've always used the default, and they may have screwed up the default.
Branch bug4795 in my Github fixed the problem for me. Erinn: Perhaps you can try a build? https://github.com/Shondoit/torbrowser/tree/bug4795
If needed, you can play with some of the flags. I know the official mozconfig with only the *-official flags disabled works as well.
Trac:
Cc: StrangeCharm, Shondoit to StrangeCharm, Shondoit, erinn
Status: new to needs_reviewReplying to phobos:
It works for me on Win 7 pro. Here is how it seem to work with different settings:
- (Full) Aero: The window buttons show up black and the in-frame pop-ups (e.g. certificate info) are transparent
- Aero Basic: The buttons show up fine, however, the pop-ups are still transparent
- Classic: Same as Aero Basic
So if you want to check if it's fixed, the best thing to do is check the certificate by clicking the lock in the address bar. (You can look at Runa's attachment to see how it looks)
I checked the release notes to make sure I was using 2.2.35-5 and I was.
Replying to phobos:
Here's what I see, attached. Mhm, that only confirms it. Your cert pop-up is transparent. And what you're seeing right now is Aero Basic. If you had full Aero the window borders (and taskbar) would be translucent.
Replying to rransom:
Replying to phobos:
it looks the same in aero full, aero basic, and classic. If you're running Windows 7 in a VM, you're not really using Aero because Windows 7 doesn't have Direct3D drivers for your VM's virtual graphics card. Partially true. It's the responsibility of the VM software manufacturer to supply proper drivers. If the driver is WDDM 1.0 compliant, then Windows can use Direct3D for rendering. VirtualBox has experimental support and I believe VMware has full WDDM support.
If you want to check if the bug is fixed, check for a transparent cert pop-up. It's the only sure-fire way.
Erinn: can you check if the mozconfig was in the source folder this time?
Replying to erinn:
Yep, it's definitely there. Are there build options that definitely fix it? I wouldn't say 'definitely fix it', but the default works just fine for me. I do
make -f windows.mk clean fetch-firefox unpack-firefox build-firefox copy-firefox bundleto make sure everything is clean and fresh.
The problem is back since Tor Browser Bundle 2.2.35-9
With 2.2.35-8 it still works at Win 7 / 32bit.
https://trac.torproject.org/projects/tor/ticket/5688
Trac:
Username: MercAnd lets not forget about the bookmark box transparency! Really, this makes me worry that TBB is not fully tested each new release...and I've been using Tor since about '02 or '03...and TBB since I first came up with the idea and Steven and I chatted on IRC, before Steven took over and made TBB.
Here's my version (rant) for bug tracker, of these issues: !https://trac.torproject.org/projects/tor/ticket/5736
Just for the sake of ease, here's the body of my bug report:
"(once again) Black buttons, transparent bookmark functions...TBB v2.2.35-9"
(extracted from the Tor Blog here: https://blog.torproject.org/blog/new-tor-browser-bundles-16 )
If you try to bookmark a page...well, good luck with all the transparency issues (see screenshot URLs below).
What confounds me is these exact issue arose in previous TBB versions, and then were (recently) fixed (at least for some versions of Windows)...but...now they're back; arrrg!
Attn. Erin, Mike, et al.:
How do you all not realize there are such noticeable and annoying bugs? With this version the minimize, maximize, and close buttons for TBB are black, and bookmark function isn't visually correct (nor particularly usable). Do you not test each new version of TBB? (that's an honest question I hope someone will answer)
SCREENSHOTS:
TBB black buttons: minimize, maximize, and close http://i.imgur.com/WsG0O.jpg
Check.torproject web site http://i.imgur.com/HiZz7.jpg
Check.torproject web site; bookmark1 http://i.imgur.com/2yTZW.jpg
Check.torproject web site; bookmark2 http://i.imgur.com/0iwEb.jpg
Replying to cypherpunks:
What confounds me is these exact issue arose in previous TBB versions, and then were (recently) fixed (at least for some versions of Windows)...but...now they're back; arrrg! I do not remember it ever being fixed, but I have not used every version since tor-browser-2.2.35-3 Can you be more specific as to what versions worked correctly and on what versions of Windows, if you remember? Perhaps it could help us narrow it down.
Hello Shondoit,
Replying to Shondoit:
Replying to cypherpunks:
What confounds me is these exact issue arose in previous TBB versions, and then were (recently) fixed (at least for some versions of Windows)...but...now they're back; arrrg!
I do not remember it ever being fixed, but I have not used every version since tor-browser-2.2.35-3 Can you be more specific as to what versions worked correctly and on what versions of Windows, if you remember? Perhaps it could help us narrow it down.
It was the last release, with Firefox 11, TBB v2.2.35-8 (https://blog.torproject.org/blog/new-tor-browser-bundles-updated-linux-again). See the attached screenshots:
- Screenshot of visible minimize, maximize, and close, as well as bookmark
- Screenshot of visible SSL cert info
@ All,
For Windows, the best screenshot program, IMO, is LigthScreen [1]. It's free, and GNU GPL :)
I love Ligthscreen because it can take screenshots of things like a cursor and the bookmark tab in my above screenshots. Many (most?) Windows screenshot software do not offer these important features, not to mention they are already GNU GPL.
Hi Phobos,
Replying to rransom:
Replying to phobos:
it looks the same in aero full, aero basic, and classic.
If you're running Windows 7 in a VM, you're not really using Aero because Windows 7 doesn't have Direct3D drivers for your VM's virtual graphics card.
Please see the attached screenshots using the current TBB (v2.2.35-9) on installed Windows 7 64 bit, classic (no Areo), with "best performance" setting under 'Control Panel':
- Screenshot of visible minimize, maximize, and close, but non-viable bookmark
- Screenshot of non-visible SSL cert info
Replying to nefanon:
Here's a temp fix I used: Change the \FirefoxPortable\App\Firefox\tbb-firefox.exe properties to use "Windows XP SP3" for compatibility. It at least shows the minimize/maximize/close buttons.
^^^ = "Vidalia was unable to start the configured web browser" for TBB v.2.2.35-9 on (installed) Windows 7 64 bit. However, when tbb-firefox.exe is allowed to run as Administrator, the bookmark and SSL cert info pop-ups are still not visually correct, even though the minimize, maximize, and close buttons are visible.
I'm pretty sure this is an upstream bug. I think I was originally able to find a better example on Mozilla's bugzilla, but here are a few of similar reports I was able to find just now:
https://bugzilla.mozilla.org/show_bug.cgi?id=693916 https://bugzilla.mozilla.org/show_bug.cgi?id=597185 https://bugzilla.mozilla.org/show_bug.cgi?id=693916
I don't know for sure whose problem it is (it could certainly be ours), but we aren't doing anything significantly different between our builds to trigger the problems, I don't think.
https://blog.torproject.org/blog/new-tor-browser-bundles-17#comment-15592 says "The minimize, maximize buttons can be restored by disabling the Firefox "App Button" by right-clicking on one of the bars at the top of the browser. Doesn't solve the problem entirely, but good enough."
This bug was introduced in 2.2.35-2. There was one patch that got added in that version, namely 0010-Provide-client-values-only-to-CSS-Media-Queries.patch. (created as 0012-* at the time.) This patch comments out a huge block inside nsMediaFeatures.cpp. If this block is re-activated, then FF's chrome is correct again.
I'll leave it up to Mike to review the existing patch, since it might introduce de-anonymizing issues to just re-enable that block.
Trac:
Owner: erinn to mikeperry
Status: reopened to assigned
Since this isn't a direct or indirect violation of our privacy and security requirements, I think it's not 'major' for us. This means we'll need help if we ever want to get this fixed.
I think one could actually call the lack of maximize button a feature due to the fingerprinting issues when doing that, though I agree lack of minimize and close is annoying.
Questions that will help solve this faster if answered:
-
Which parts of the CSS patch actually make a difference?
-
Why does the browser chrome give a shit about media features that are supposed to be for HTML content?
-
Is the patch responsible even for the menu transparency issues too, or just the titlebar buttons?
Trac:
Priority: major to normal-
Replying to mikeperry:
Since this isn't a direct or indirect violation of our privacy and security requirements, I think it's not 'major' for us. This means we'll need help if we ever want to get this fixed.
I think one could actually call the lack of maximize button a feature due to the fingerprinting issues when doing that, though I agree lack of minimize and close is annoying.
Questions that will help solve this faster if answered:
-
Which parts of the CSS patch actually make a difference?
-
Why does the browser chrome give a shit about media features that are supposed to be for HTML content?
-
Is the patch responsible even for the menu transparency issues too, or just the titlebar buttons?
I'm changing it back to major, just to make a point (I agree with arma). You seem to poo-poo this issue, and even try to make a point that it shouldn't be fixed(!), but it's a MAJOR issue to people that use TBB, even if it's not a big deal to you._ And it's more than minimize, the bookmark features are mostly useless, as are the SSL window and the add-on window, e.g., if I wanted to check the cert info, or if I wanted to add BetterPrivacy to Windows TBB._
This issue scares a lot of TBB users, and rightly so, it's quite egregious and noticeable. What do you expect non-computer savvy people to think? I for one wouldn't use TBB in it's current state if I didn't know what's going on with this issue...
I will donate money to get this fixed, and keep it a major issue,if that would help hire a Windows dev (if s/he is needed), even if for just this single issue. I'm not sure how much it would cost, but I could send in ~>$500 next week, if that would help; even though that's not a lot of money, it is to me, I'm not rich, but I fully understand how important it is to get this bug fixed. I think some at Tor don't focus enough on the useability of the software; that is, some Tor devs see the trees but not the forest...
Trac:
Priority: normal to minor-
I agree, this is important to get fixed. It's a crazy big usability bug, and - while probably not catastrophic for anonymity - a major confidence inhibitor in TBB. I'm changing the priority back to major, if you still disagree mike - especially wrt the ssl/bookmark settings - please change it back.
Trac:
Priority: minor to majorReplying to Sebastian:
I agree, this is important to get fixed. It's a crazy big usability bug, and - while probably not catastrophic for anonymity - a major confidence inhibitor in TBB. I'm changing the priority back to major, if you still disagree mike - especially wrt the ssl/bookmark settings - please change it back.
Hi Sebastian,
Thanks for changing it from minor to major. I meant to change it from normal to major, but I chose minor on accident.
Replying to arma:
https://blog.torproject.org/blog/new-tor-browser-bundles-17#comment-15592 says "The minimize, maximize buttons can be restored by disabling the Firefox "App Button" by right-clicking on one of the bars at the top of the browser. Doesn't solve the problem entirely, but good enough."
I tried the above, but there isn't anything called "App Button", unless the OP means "Add-on bar"; see attached screenshot "" (using the current TBB). When I disable "Add-on bar", and restart, nothing beneficial occurs wrt minimize buttons, and etc.
Replying to mikeperry:
Since this isn't a direct or indirect violation of our privacy and security requirements, I think it's not 'major' for us. This means we'll need help if we ever want to get this fixed. arma changed this to major because of the high rate of mentions (see comment 33.) Also, because it's been a bug for months I suggest keeping this as major. My two cents.
I think one could actually call the lack of maximize button a feature due to the fingerprinting issues when doing that, though I agree lack of minimize and close is annoying. The buttons are only invisible. It still works when clicking in the middle of the black bar. As well as the other options to maximize (right click title bar + maximize, win7: drag against top, alt + space + x) this is hardly a 'feature'.
- Which parts of the CSS patch actually make a difference? This is an interesting one. The patch comments out an entire block of //Mozilla extensions, but this section contains things like '_moz_windows_default_theme', '_moz_windows_compositor' and '_moz_windows_theme'. I reckon a combination of these removed features is responsible for the black control box and the transparency issues. It will take some time to figure out which ones. Check out nsMediaFeatures.cpp, line 459 and down. I'm not sure removing this block of features was the best course of action. I recommend rereading the source and revising this choice if needed.
- Why does the browser chrome give a shit about media features that are supposed to be for HTML content? Because this is not only for HTML content but rather for chrome in general? Because Firefox supports theming and uses these features for compositing? I have no idea and this question is better asked in Mozilla channels.
- Is the patch responsible even for the menu transparency issues too, or just the titlebar buttons? Yes, it's responsible for the menu transparency issues too.
