Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4796 closed defect (fixed)

circuitlist.c:1222: _circuit_mark_for_close: Assertion ocirc->rend_data failed; aborting

Reported by: rransom Owned by: rransom
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version: Tor: 0.2.3.10-alpha
Severity: Keywords: tor-hs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

murb reports the following error message in 0.2.3.10-alpha:

Dec 28 15:59:37.000 [err] _circuit_mark_for_close(): Bug: circuitlist.c:1222: _circuit_mark_for_close: Assertion ocirc->rend_data failed; aborting

There were no relevant notices or warnings before this message.

I see several code paths which can set a circuit's purpose to CIRCUIT_PURPOSE_C_INTRODUCING, then mark it for close before its rend_data field is set; there's no way we can get rid of those paths. Time to remove this assertion.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by rransom

Status: newneeds_review

See my bug4796 branch for a fix.

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good; merging.

comment:3 Changed 7 years ago by nickm

Keywords: tor-hs added

comment:4 Changed 7 years ago by nickm

Component: Tor Hidden ServicesTor
Note: See TracTickets for help on using tickets.