Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#4837 closed defect (fixed)

Log message about enabling renegotiation in OpenSSL 0.9.8l is inconsistent with behaviour

Reported by: rransom Owned by:
Priority: Low Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From tor_tls_init:

    if (version >= 0x009080c0L && version < 0x009080d0L) {
      log_notice(LD_GENERAL, "OpenSSL %s looks like version 0.9.8l; "
                 "I will try SSL3_FLAGS to enable renegotation.",
                 SSLeay_version(SSLEAY_VERSION));
      use_unsafe_renegotiation_flag = 1;
      use_unsafe_renegotiation_op = 1;

The log message is inconsistent with Tor's behaviour. What should be changed here?

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by nickm

The log message should probably change. We do that behavior because (IIRC) of some weird platform that claimed to be 0.9.8l but which supported the OP anyway.

comment:2 Changed 9 years ago by nickm

Resolution: fixed
Status: newclosed

committed 411cf8f71455926db119259545ac8d5c80a5fb58 with a fix

comment:3 Changed 8 years ago by nickm

Keywords: tor-client added

comment:4 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.