Opened 8 years ago

Last modified 5 months ago

#4857 new defect

Disabling an HS with service-side rend circs in progress may produce ‘Internal Error’ log message

Reported by: rransom Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs logging annoyance
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

From rend_service_rendezvous_has_opened:

  service = rend_service_get_by_pk_digest(
                circuit->rend_data->rend_pk_digest);
  if (!service) {
    log_warn(LD_GENERAL, "Internal error: unrecognized service ID on "
             "introduction circuit.");
    reason = END_CIRC_REASON_INTERNAL;
    goto err;
  }

When a hidden service is removed from Tor's configuration, rend_config_services closes its introduction circuits, but not its rendezvous circuits. Leaving in-progress rend circs open can trigger this ‘Internal Error’ log message.

Child Tickets

Change History (8)

comment:1 Changed 8 years ago by rransom

rend_service_set_connection_addr_port will fuss about open rend circs if the client tries to use them again:

  service = rend_service_get_by_pk_digest(
                circ->rend_data->rend_pk_digest);
  if (!service) {
    log_warn(LD_REND, "Couldn't find any service associated with pk %s on "
             "rendezvous circuit %d; closing.",
             serviceid, circ->_base.n_circ_id);
    return -1;
  }

But we probably shouldn't close already-open rendezvous circuits (and the open streams on them) when the service goes away; quieting this log message a bit should be enough.

comment:2 Changed 7 years ago by rransom

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

Harmless, hard-to-trigger warn-level log messages aren't going to be fixed on 0.2.3.x.

comment:3 Changed 7 years ago by nickm

Keywords: tor-hs added

comment:4 Changed 7 years ago by nickm

Component: Tor Hidden ServicesTor

comment:5 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: unspecified

comment:6 Changed 3 years ago by dgoulet

Points: small
Priority: MediumVery Low
Severity: Normal

comment:7 Changed 2 years ago by nickm

Keywords: logging annoyance added
Points: small1

comment:8 Changed 5 months ago by arma

See #13800 for pretty much the same ticket.

Note: See TracTickets for help on using tickets.