Opened 7 years ago

Last modified 2 years ago

#4885 new enhancement

Make all paths absolute

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client configuration usability torrc
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor:

Description

There are bunches of cases internally where it would make sense to have all the paths in Tor be absolute, and none (that I can think of) where taking paths as relative to the CWD actually helps us.

We could find things that should be absolute and make them so piecemeal, but that would invite missed cases. Better, we we could just turn all paths into absolute paths when we read them in from the configuration.

(See #1101 and #4881 for earlier work here. Marking this for 0.2.4.x, since 0.2.3.x is approaching feature freeze.)

Child Tickets

Change History (10)

comment:1 Changed 7 years ago by atagar

One minor thing to think about is how this would work with GETCONF / SETCONF / SAVECONF. If the DataDirectory is converted to an absolute path right after reading the torrc or a SETCONF then other use cases will have issues. For instance...

  • User runs TBB.
  • Vidalia issues a SAVECONF, converting their once relative DataDirectory to be absolute.
  • The TBB directory is moved and TBB is run again, causing a DataDirectory will be created at the old location.

Making 'options_get_datadir_fname2_suffix' expand the paths might avoid those issues - haven't looked.

comment:2 Changed 7 years ago by nickm

Keywords: tor-client added

comment:3 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:4 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:5 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:6 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:8 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:9 Changed 2 years ago by nickm

Keywords: configuration usability torrc added
Severity: Normal

Atagar's comment above is right: we'd want to have the user-configured string remain stable wrt getconf and setconf and saveconf, but have the value that the rest of Tor sees be the absolute one.

comment:10 Changed 2 years ago by nickm

Points: 3
Note: See TracTickets for help on using tickets.