Make all paths absolute

[nickm]

There are bunches of cases internally where it would make sense to have all the paths in Tor be absolute, and none (that I can think of) where taking paths as relative to the CWD actually helps us.

We could find things that should be absolute and make them so piecemeal, but that would invite missed cases. Better, we we could just turn all paths into absolute paths when we read them in from the configuration.

(See #1101 and #4881 for earlier work here. Marking this for 0.2.4.x, since 0.2.3.x is approaching feature freeze.)

[atagar]

One minor thing to think about is how this would work with GETCONF / SETCONF / SAVECONF. If the DataDirectory is converted to an absolute path right after reading the torrc or a SETCONF then other use cases will have issues. For instance...

• User runs TBB.
• Vidalia issues a SAVECONF, converting their once relative DataDirectory to be absolute.
• The TBB directory is moved and TBB is run again, causing a DataDirectory will be created at the old location.

Making 'options_get_datadir_fname2_suffix' expand the paths might avoid those issues - haven't looked.

[teor]

Milestone renamed

[nickm]

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

[nickm]

Remove an old triaging keyword.

[nickm]

Atagar's comment above is right: we'd want to have the user-configured string remain stable wrt getconf and setconf and saveconf, but have the value that the rest of Tor sees be the absolute one.